schwartz zipple: cleanup debug prints

src/groth16/schzip.cairo

@@ -122,12 +122,6 @@ impl SchZipPolyCommitHandler of SchZipPolyCommitHandlerTrait {
  let l3_x = SchZipEval::eval_01234(l3, self.fiat_shamir_powers, f_nz);
  let w_x = SchZipEval::eval_fq12(witness.into(), self.fiat_shamir_powers, f_nz);
 
- println!(
- "#zero_bit\nx = {}\nf = {f}\nl1 = {l1}\nl2 = {l2}\nl3 = {l3}\nw = {witness}",
- *self.fiat_shamir_powers[1]
- );
- println!("f_x = {f_x}\nl1_x = {l1_x}\nl2_x = {l2_x}\nl3_x = {l3_x}\nw_x = {w_x}");
-
  // RHS = F(x) * F(x) * L1(x) * L2(x) * L3(x) * Witness(x)
  let rhs: u512 = f_x.sqr().u_mul(l1_x * l2_x * l3_x * w_x);
 
@@ -151,13 +145,6 @@ impl SchZipPolyCommitHandler of SchZipPolyCommitHandlerTrait {
  // LHS = R(x) + Q(x) * P12(x)
  let lhs = r_x + mul_u(q_x, *self.p12_x);
 
- println!("r: {}", r);
- println!("r_x: {}", fq(u512_reduce(r_x, f_nz)));
- println!("q_x: {}", fq(q_x));
-
- println!("rhs: {}", fq(u512_reduce(rhs, f_nz)));
- println!("lhs: {}", fq(u512_reduce(lhs, f_nz)));
-
  // assert rhs == lhs mod field, or rhs - lhs == 0
  assert(u512_reduce(rhs - lhs, f_nz) == 0, 'SchZip 1/-1 bit verif failed');
 
@@ -179,22 +166,40 @@ impl SchZipPolyCommitHandler of SchZipPolyCommitHandlerTrait {
  f_nz: NZ256
  ) {
  let c = self.coefficients;
- f =
- fq12(
- *c[i],
- *c[i + 1],
- *c[i + 2],
- *c[i + 3],
- *c[i + 4],
- *c[i + 5],
- *c[i + 6],
- *c[i + 7],
- *c[i + 8],
- *c[i + 9],
- *c[i + 10],
- *c[i + 11],
- );
- f = direct_to_tower(f);
+
+ // F(x) * F(x) * L1(x) * L2(x) * L3(x) * Witness(x) = R(x) + Q(x) * P12(x)
+ let f_x = SchZipEval::eval_fq12_direct(f.into(), self.fiat_shamir_powers, f_nz);
+ let l1_x = SchZipEval::eval_01234(l1, self.fiat_shamir_powers, f_nz);
+ let l2_x = SchZipEval::eval_01234(l2, self.fiat_shamir_powers, f_nz);
+ let l3_x = SchZipEval::eval_01234(l3, self.fiat_shamir_powers, f_nz);
+
+ // RHS = F(x) * F(x) * L1(x) * L2(x) * L3(x) * Witness(x)
+ let rhs: u512 = f_x.sqr().u_mul(l1_x * l2_x * l3_x);
+
+ let r = fq12(
+ *c[i],
+ *c[i + 1],
+ *c[i + 2],
+ *c[i + 3],
+ *c[i + 4],
+ *c[i + 5],
+ *c[i + 6],
+ *c[i + 7],
+ *c[i + 8],
+ *c[i + 9],
+ *c[i + 10],
+ *c[i + 11],
+ );
+
+ let r_x = SchZipEval::eval_fq12_direct_u(r.into(), self.fiat_shamir_powers, f_nz);
+ let q_x = SchZipEval::eval_poly_52(c, i + 12, self.fiat_shamir_powers, f_nz);
+ // LHS = R(x) + Q(x) * P12(x)
+ let lhs = r_x + mul_u(q_x, *self.p12_x);
+
+ // assert rhs == lhs mod field, or rhs - lhs == 0
+ assert(u512_reduce(rhs - lhs, f_nz) == 0, 'SchZip 1/-1 bit verif failed');
+
+ f = direct_to_tower(r);
  }
 }
 

src/groth16/schzip_base.cairo

@@ -306,6 +306,7 @@ impl SchZipEval of SchZipEvalTrait {
  polynomial: @Array<u256>, i: u32, fiat_shamir_pow: @Array<u256>, f_nz: NZ256
  ) -> u512 {
  // We can do 16 additions without overflow
+ // term 1 * x ^ 1 + term 0
  let mut acc1 = u512_add_u256(
  mul_u(*fiat_shamir_pow[1], *polynomial[i + 1]), *polynomial[i]
  );
@@ -348,9 +349,19 @@ impl SchZipEval of SchZipEvalTrait {
  polynomial: @Array<u256>, i: u32, fiat_shamir_pow: @Array<u256>, f_nz: NZ256
  ) -> u256 { //
  core::internal::revoke_ap_tracking();
+
  // Process first 30 terms
  let acc1 = SchZipEval::eval_poly_30_u(polynomial, i, fiat_shamir_pow, f_nz);
 
+ // let mut ci = 0;
+ // println!("q_0_29 = poly(");
+ // while ci != 30 {
+ // println!("#term{}({}){},", ci, i + ci, fq(*polynomial[i + ci]));
+ // ci += 1;
+ // };
+ // println!(")");
+ // println!("q_x_0_29 = {}", fq(u512_reduce(acc1, f_nz)));
+
  // Process next 16 terms, i 30 - 45
  let mut acc2 = mul_u(*fiat_shamir_pow[30], *polynomial[i + 30]);
  acc2 = u512_add(acc2, mul_u(*fiat_shamir_pow[31], *polynomial[i + 31]));
@@ -369,6 +380,7 @@ impl SchZipEval of SchZipEvalTrait {
  acc2 = u512_add(acc2, mul_u(*fiat_shamir_pow[44], *polynomial[i + 44]));
  acc2 = u512_add(acc2, mul_u(*fiat_shamir_pow[45], *polynomial[i + 45]));
 
+ // Process las batch of terms, i 46 - 51
  let mut acc3 = mul_u(*fiat_shamir_pow[46], *polynomial[i + 46]);
  acc3 = u512_add(acc3, mul_u(*fiat_shamir_pow[47], *polynomial[i + 47]));
  acc3 = u512_add(acc3, mul_u(*fiat_shamir_pow[48], *polynomial[i + 48]));