Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional functions and documentation #1

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

TorkelV
Copy link
Contributor

@TorkelV TorkelV commented Mar 14, 2024

No description provided.

@TorkelV TorkelV requested a review from mortennost March 14, 2024 12:51
Copy link
Collaborator

@mortennost mortennost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Check NIT's about comments 😉

Comment on lines 93 to 95
/**
* Fetch the documentReference ignoring exceptions.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: "Fetch the DocumentSnapshot ignoring exceptions"

Comment on lines 104 to 106
/**
* Fetch the documentReference from cache ignoring exceptions.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: "Fetch the DocumentSnapshot ignoring exceptions"

@TorkelV TorkelV merged commit 1b6a0ef into master Mar 14, 2024
@TorkelV TorkelV deleted the feature/documentation branch March 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants