Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn run v1.22.4 #753

Merged
merged 7 commits into from
Oct 4, 2020
Merged

Fix yarn run v1.22.4 #753

merged 7 commits into from
Oct 4, 2020

Conversation

bertoort
Copy link
Contributor

@bertoort bertoort commented Oct 3, 2020

$ jest App
Done in 5.66s. #724

Notes:

$ jest App
Done in 5.66s. shootismoke#724
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Could you add a github job inside .github/worflows/pr.yml, and see if it works?

Something like:

  test-unit:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - run: yarn install
      - run: yarn test:unit

Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! I just added some suggestions to add some comments in file configs.

babel.config.js Show resolved Hide resolved
jest.config.js Show resolved Hide resolved
jest.config.js Show resolved Hide resolved
jest.config.js Show resolved Hide resolved
jest.config.js Outdated Show resolved Hide resolved
@amaury1093 amaury1093 merged commit 1b7e89e into shootismoke:master Oct 4, 2020
@amaury1093 amaury1093 mentioned this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants