Setup translations

[lucienbl]

This should setup the translations in order to translate the app! There might be some missing strings I forgot to add but most of them are done.

[lucienbl]

Seems to be some indentation issues, will run lint and update the pull request!

[amaury1093]

Thanks, that was fast! I'll have a look tonight.

You can run yarn lint --fix to fix most of them

[lucienbl]

Thanks! Has been done 👍

[amaury1093]

Very nice, works well! I have just a couple of small comments, and then we can merge.

[amaury1093]

@lucienbl Could you actually create another new PR with commit 5d2f0a0? Each PR should have only one purpose

[lucienbl]

Sure, github actually added them automatically how can I remove them from the pr? 🤔

[amaury1093]

how can I remove them from the pr?

Have a look at git rebase -i HEAD~10, drop the commit, and git push --force again. Be sure to backup the dropped commit first.

[lucienbl]

Okay got it to create a separate pull request (#70) but to create a "clean" pull request for translations, do I have to rebase a new on and delete this pull request (#69) ? Thanks :)

Edit: #69 & #70 should be clean now 👍

[amaury1093]

lgtm!