Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add detox with a simple e2e test #396

Merged
merged 20 commits into from
Apr 10, 2020
Merged

test: Add detox with a simple e2e test #396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5d09596
Try with latest detox
amaury1093 Apr 9, 2020
05e05c4
Try on Github action
amaury1093 Apr 10, 2020
1f91aa0
Fix syntax
amaury1093 Apr 10, 2020
86c153a
Generate app.json
amaury1093 Apr 10, 2020
7d02c9d
Remove test
amaury1093 Apr 10, 2020
05c612a
Show yarn start output
amaury1093 Apr 10, 2020
f1c17be
Try tunnel
amaury1093 Apr 10, 2020
f2f9775
Correct start command
amaury1093 Apr 10, 2020
b3a48ad
No tunnel
amaury1093 Apr 10, 2020
f6014dc
Give some buffer
amaury1093 Apr 10, 2020
98baa73
Record videos
amaury1093 Apr 10, 2020
8b8522b
Fix command
amaury1093 Apr 10, 2020
355899b
Always upload artifact
amaury1093 Apr 10, 2020
7a47748
Update version
amaury1093 Apr 10, 2020
c0378f0
Add a waitFor
amaury1093 Apr 10, 2020
dcb2797
Timeout 3min
amaury1093 Apr 10, 2020
d870f1f
30 min timeout
amaury1093 Apr 10, 2020
5accfe0
Add timeout for 1st test
amaury1093 Apr 10, 2020
7919605
Add console
amaury1093 Apr 10, 2020
68c9d01
reloadApp beforeAll
amaury1093 Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give some buffer
  • Loading branch information
@amaury1093
amaury1093 committed Apr 10, 2020
commit f6014dc67c589839cfc7ced076a5d3f451f300fe
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Run E2E Tests
run: |
# Start packager in background
yarn start &
yarn start >/dev/null &
PID=$(ps $! | tail -1 | awk '{print $1}')
# Run e2e test
yarn test:e2e
Expand Down
5 changes: 4 additions & 1 deletion e2e/locationDenied.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// You should have received a copy of the GNU General Public License
// along with Sh**t! I Smoke. If not, see <https://www.gnu.org/licenses/>.

import { by, element, expect } from 'detox';
import { by, element, expect, waitFor } from 'detox';
import { reloadApp } from 'detox-expo-helpers';

import { testIds } from '../App/util/testId';
Expand All @@ -25,6 +25,9 @@ describe('Location denied', () => {
permissions: { location: 'never' },
});

waitFor(element(by.id(testIds.Error.screen)))
.toExist()
.withTimeout(30000);
await expect(element(by.id(testIds.Error.screen))).toBeVisible();
});

Expand Down