Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Edit read me file #295

Closed
wants to merge 4 commits into from

Conversation

jayadevvasudevan
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

I think too much text at the top of the README would not appeal to users, I would prefer something visual on the top. Can you move this section to below the screenshots, and above the "Try it on Expo" section? Thanks a lot!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 changed the title Edited read me file chore: Edit read me file Oct 21, 2019
@amaury1093
Copy link
Member

relates to #301

jayadevvasudevan and others added 2 commits October 22, 2019 23:09
Co-Authored-By: Amaury Martiny <[email protected]>
Co-Authored-By: Amaury Martiny <[email protected]>
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after this comment is addressed:

I think too much text at the top of the README would not appeal to users, I would prefer something visual on the top. Can you move this section to below the screenshots, and above the "Try it on Expo" section? Thanks a lot!

@amaury1093 amaury1093 added the invalid This doesn't seem right label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants