Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand share dialog on iOS (#250) #278

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

DragonSpirit
Copy link
Contributor

Hi! I improve iOS share menu like I show here. On android it's kind of difficult to implement in with expo, maybe it will work in future.
It would be great if you check in on physical device because I am android owner 😬

Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @DragonSpirit! The code looks good, except for two tiny nits about alphabetical ordering.

I'll find an iOS device to test this this week, and then we can merge.

App/Screens/ShareScreen/ShareScreen.tsx Outdated Show resolved Hide resolved
App/Screens/ShareScreen/ShareScreen.tsx Outdated Show resolved Hide resolved
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this looks perfect. Btw I've updated the coding styleguide in CONTRIBUTING.md: https://github.com/amaurymartiny/shoot-i-smoke/blob/master/CONTRIBUTING.md#use-a-consistent-coding-style

@amaury1093
Copy link
Member

Works well

@amaury1093 amaury1093 merged commit 0a37241 into shootismoke:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants