Run eslint

.eslintrc.js

@@ -0,0 +1,20 @@
+module.exports = {
+ env: {
+ jest: true
+ },
+ extends: [
+ 'prettier',
+ 'prettier/standard',
+ 'prettier/@typescript-eslint',
+ 'semistandard'
+ ],
+ parser: '@typescript-eslint/parser',
+ plugins: ['react', '@typescript-eslint'],
+ rules: {
+ // https://stackoverflow.com/questions/55280555/typescript-eslint-eslint-plugin-error-route-is-defined-but-never-used-no-un
+ '@typescript-eslint/no-unused-vars': 'error',
+ 'no-unused-vars': 'off',
+ 'react/jsx-uses-react': 1,
+ 'react/jsx-uses-vars': 1
+ }
+};

.vscode/settings.json

@@ -0,0 +1,11 @@
+{
+ "eslint.validate": [
+ "javascript",
+ "javascriptreact",
+ "typescript",
+ "typescriptreact"
+ ],
+ "eslint.alwaysShowStatus": true,
+ "eslint.autoFixOnSave": true,
+ "editor.formatOnSave": true
+}

App/App.tsx

@@ -32,7 +32,7 @@ if (Constants.manifest.extra.sentryPublicDsn) {
  Sentry.config(Constants.manifest.extra.sentryPublicDsn).install();
 }
 
-export function App() {
+export function App () {
  const [fontLoaded, setFontLoaded] = useState(false);
  useEffect(() => {
  Font.loadAsync({

App/Screens/About/About.tsx

@@ -34,7 +34,7 @@ import * as theme from '../../utils/theme';
 
 interface AboutProps extends NavigationInjectedProps {}
 
-export function About(props: AboutProps) {
+export function About (props: AboutProps) {
  const handleOpenAmaury = () =>
  Linking.openURL('https://twitter.com/amaurymartiny');
 

App/Screens/About/Box/Box.tsx

@@ -21,7 +21,7 @@ import cigarette from '../../../../assets/images/cigarette.png';
 import { i18n } from '../../../localization';
 import * as theme from '../../../utils/theme';
 
-export function Box() {
+export function Box () {
  return (
  <View style={styles.box}>
  <View style={styles.equivalence}>

App/Screens/About/Language/Language.tsx

@@ -22,7 +22,7 @@ import * as names from './names.json';
 import { ApiContext } from '../../../stores';
 import * as theme from '../../../utils/theme';
 
-export function Language() {
+export function Language () {
  const { reloadApp } = useContext(ApiContext);
 
  const handleValueChange = (itemValue: string) => {

App/Screens/Details/Details.tsx

@@ -27,14 +27,13 @@ import { Header } from './Header';
 import { i18n } from '../../localization';
 import { ApiContext, CurrentLocationContext } from '../../stores';
 import { distanceToStation, getCorrectLatLng } from '../../utils/station';
-import * as theme from '../../utils/theme';
 
 interface DetailsProps extends NavigationInjectedProps {}
 
 // Holds the ref to the MapView.Marker representing the AQI station
 let stationMarker: Marker | undefined;
 
-export function Details(props: DetailsProps) {
+export function Details (props: DetailsProps) {
  const { navigation } = props;
 
  const [showMap, setShowMap] = useState(false);

App/Screens/Details/Distance/Distance.tsx

@@ -25,7 +25,7 @@ interface DistanceProps {
  distance: number;
 }
 
-export function Distance(props: DistanceProps) {
+export function Distance (props: DistanceProps) {
  return (
  <Banner elevated shadowPosition="top" style={styles.banner}>
  <Text style={styles.distance}>

App/Screens/Details/Header/Header.tsx

@@ -39,7 +39,7 @@ interface HeaderProps {
  onBackClick: (event: GestureResponderEvent) => void;
 }
 
-export function Header(props: HeaderProps) {
+export function Header (props: HeaderProps) {
  const { onBackClick } = props;
  const { api } = useContext(ApiContext);
  const { currentLocation } = useContext(CurrentLocationContext);

App/Screens/ErrorScreen/ErrorScreen.tsx

@@ -25,7 +25,7 @@ import * as theme from '../../utils/theme';
 
 interface ErrorScreenProps extends NavigationInjectedProps {}
 
-export function ErrorScreen(props: ErrorScreenProps) {
+export function ErrorScreen (props: ErrorScreenProps) {
  const { error } = useContext(ErrorContext);
 
  return (

App/Screens/Home/Header/Header.tsx

@@ -36,7 +36,7 @@ interface HeaderProps {
  onChangeLocationClick: (event: GestureResponderEvent) => void;
 }
 
-export function Header(props: HeaderProps) {
+export function Header (props: HeaderProps) {
  const { api } = useContext(ApiContext)!;
  const { currentLocation } = useContext(CurrentLocationContext);
  const { onChangeLocationClick } = props;

App/Screens/Home/Home.tsx

@@ -37,21 +37,21 @@ import * as theme from '../../utils/theme';
 
 interface HomeProps extends NavigationInjectedProps {}
 
-export function Home(props: HomeProps) {
+export function Home (props: HomeProps) {
  const { api } = useContext(ApiContext)!;
  const { currentLocation } = useContext(CurrentLocationContext);
 
  const isTooFar = isStationTooFar(currentLocation!, api!);
 
- function goToAbout() {
+ function goToAbout () {
  props.navigation.navigate('About');
  }
 
- function goToDetails() {
+ function goToDetails () {
  props.navigation.navigate('Details');
  }
 
- function handleShare() {
+ function handleShare () {
  return Share.share({
  title: i18n.t('home_share_title'),
  message: i18n.t('home_share_message', {
@@ -109,14 +109,14 @@ export function Home(props: HomeProps) {
  );
  };
 
- function renderPresentPast() {
+ function renderPresentPast () {
  const time = new Date().getHours();
 
  if (time < 15) return i18n.t('home_common_you_ll_smoke');
  return i18n.t('home_common_you_smoked');
  }
 
- function renderShit() {
+ function renderShit () {
  if (api!.shootISmoke.cigarettes <= 1) return i18n.t('home_common_oh');
 
  // Return a random swear word

App/Screens/Home/SmallButton/SmallButton.tsx

@@ -30,7 +30,7 @@ interface SmallButtonProps extends TouchableOpacityProps {
  text: string;
 }
 
-export function SmallButton({ text, icon, ...rest }: SmallButtonProps) {
+export function SmallButton ({ text, icon, ...rest }: SmallButtonProps) {
  return (
  <TouchableOpacity style={styles.container} {...rest}>
  {icon && (

App/Screens/Home/SmokeVideo/SmokeVideo.tsx

@@ -21,7 +21,7 @@ import { Dimensions, StyleSheet, View } from 'react-native';
 import smokeVideo from '../../../../assets/video/smoke_bg_fafafc.mp4';
 import { ApiContext } from '../../../stores';
 
-export function SmokeVideo() {
+export function SmokeVideo () {
  const { api } = useContext(ApiContext)!;
  const {
  shootISmoke: { cigarettes }
@@ -41,7 +41,7 @@ export function SmokeVideo() {
  );
 }
 
-function getVideoStyle(cigarettes: number) {
+function getVideoStyle (cigarettes: number) {
  if (cigarettes <= 1) return { backgroundColor: '#FFFFFFCC' };
  if (cigarettes < 5) return { backgroundColor: '#FFFFFFAA' };
  if (cigarettes < 15) return { backgroundColor: '#FFFFFF22' };

App/Screens/Loading/Background.tsx

@@ -24,7 +24,7 @@ interface BackgroundProps {
  style?: StyleProp<ViewStyle>;
 }
 
-export function Background(props: BackgroundProps) {
+export function Background (props: BackgroundProps) {
  return <View style={[styles.container, props.style]}>{props.children}</View>;
 }
 

App/Screens/Loading/Loading.tsx

@@ -25,14 +25,14 @@ import * as theme from '../../utils/theme';
 // The variable returned by setTimeout for longWaiting
 let longWaitingTimeout: NodeJS.Timeout | null = null;
 
-function clearLongWaiting() {
+function clearLongWaiting () {
  if (longWaitingTimeout) {
  clearTimeout(longWaitingTimeout);
  longWaitingTimeout = null;
  }
 }
 
-export function Loading() {
+export function Loading () {
  const { api } = useContext(ApiContext);
  const gps = useContext(GpsLocationContext);
 
@@ -62,7 +62,7 @@ export function Loading() {
  );
 }
 
-function renderCough(index: number) {
+function renderCough (index: number) {
  return (
  <Text key={index}>
  {i18n.t('loading_title_cough')}
@@ -71,7 +71,7 @@ function renderCough(index: number) {
  );
 }
 
-function renderText(longWaiting: boolean, gps?: Location, api?: Api) {
+function renderText (longWaiting: boolean, gps?: Location, api?: Api) {
  let coughs = 0; // Number of times to show "Cough..."
  if (gps) ++coughs;
  if (longWaiting) ++coughs;

App/Screens/Screens.tsx

@@ -31,7 +31,7 @@ import { Search } from './Search';
 import { Api, ApiContext, ErrorContext } from '../stores';
 import * as theme from '../utils/theme';
 
-function stackNavigatorOptions(initialRouteName: string) {
+function stackNavigatorOptions (initialRouteName: string) {
  return {
  cardStyle: {
  backgroundColor: theme.backgroundColor
@@ -84,7 +84,7 @@ const ErrorStack = createAppContainer(
  )
 );
 
-export function Screens() {
+export function Screens () {
  const { api } = useContext(ApiContext);
  const { error } = useContext(ErrorContext);
 
@@ -93,7 +93,7 @@ export function Screens() {
  return <View style={theme.fullScreen}>{stack}</View>;
 }
 
-function renderScreen(api?: Api, error?: string) {
+function renderScreen (api?: Api, error?: string) {
  if (error) {
  return <ErrorStack />;
  }

App/Screens/Search/Item/Item.tsx

@@ -14,7 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Sh**t! I Smoke. If not, see <http:https://www.gnu.org/licenses/>.
 
-import * as t from 'io-ts';
 import React from 'react';
 import { Image, StyleSheet, Text, TouchableOpacity, View } from 'react-native';
 
@@ -28,7 +27,7 @@ interface ItemProps {
  onClick: (item: Location) => void;
 }
 
-export function Item(props: ItemProps) {
+export function Item (props: ItemProps) {
  const { item, onClick } = props;
 
  const { city, country, county, _geoloc, locale_names: localeNames } = item;

App/Screens/Search/Search.tsx

@@ -74,7 +74,7 @@ const AxiosResponseT = t.type({
  })
 });
 
-function fetchAlgolia(search: string, gps?: LatLng) {
+function fetchAlgolia (search: string, gps?: LatLng) {
  return retry(algoliaUrls.length, status =>
  pipe(
  TE.rightIO(
@@ -104,11 +104,11 @@ function fetchAlgolia(search: string, gps?: LatLng) {
  Constants.manifest.extra.algoliaApplicationId &&
  Constants.manifest.extra.algoliaApiKey
  ? {
-  'X-Algolia-Application-Id':
+ 'X-Algolia-Application-Id':
  Constants.manifest.extra.algoliaApplicationId,
-  'X-Algolia-API-Key':
+ 'X-Algolia-API-Key':
  Constants.manifest.extra.algoliaApiKey
-  }
+ }
  : undefined,
 
  timeout: 3000
@@ -145,7 +145,7 @@ let typingTimeout: NodeJS.Timeout | null = null;
 
 interface SearchProps extends NavigationInjectedProps {}
 
-export function Search(props: SearchProps) {
+export function Search (props: SearchProps) {
  const { setCurrentLocation } = useContext(CurrentLocationContext);
  const { setError } = useContext(ErrorContext);
  const gps = useContext(GpsLocationContext);
@@ -157,7 +157,7 @@ export function Search(props: SearchProps) {
  const [search, setSearch] = useState('');
  const [hits, setHits] = useState<AlgoliaHit[]>([]);
 
- function handleChangeSearch(s: string) {
+ function handleChangeSearch (s: string) {
  setSearch(s);
  setAlgoliaError(undefined);
  setHits([]);
@@ -192,13 +192,13 @@ export function Search(props: SearchProps) {
  }, 500);
  }
 
- function handleItemClick(item: Location) {
+ function handleItemClick (item: Location) {
  // Reset everything when we choose a new location.
  setCurrentLocation(item);
  setError(undefined);
  }
 
- function renderItem({ item }: { item: AlgoliaHit }) {
+ function renderItem ({ item }: { item: AlgoliaHit }) {
  return <Item item={item} onClick={handleItemClick} />;
  }
 
@@ -226,7 +226,7 @@ export function Search(props: SearchProps) {
  );
 }
 
-function renderInfoText(
+function renderInfoText (
  algoliaError: Error | undefined,
  hits: AlgoliaHit[],
  loading: boolean,
@@ -239,7 +239,7 @@ function renderInfoText(
  return 'Waiting for results.';
 }
 
-function renderSeparator() {
+function renderSeparator () {
  return <View style={styles.separator} />;
 }
 

App/Screens/Search/SearchHeader/SearchHeader.tsx

@@ -27,7 +27,7 @@ interface SearchHeaderProps {
  search: string;
 }
 
-export function SearchHeader(props: SearchHeaderProps) {
+export function SearchHeader (props: SearchHeaderProps) {
  const { onChangeSearch, search } = props;
 
  return (