Fix: Replaced the change location image #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR @jamespearson! In order to merge this PR and not break the current design, would you mind adding the text "Change Location" back, as a Text node? font familiy: https://github.com/amaurymartiny/shoot-i-smoke/blob/master/App/util/theme.ts#L24 Thanks! |
|
Changed the Change Location button to a separate component. Before: After: (Note: Before is taken from the App store version) |
jamespearson
force-pushed
the
82-replaced-change-location-icon
branch
from
ebcadc1
to
f2a17d2
Compare
jamespearson
changed the title
amaury1093
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #82
Replaced the previous change location icon (with text) with the new one from the issue (without text)