Change Location icon should not contain text

[amaury1093]

https://github.com/amaurymartiny/shoot-i-smoke/blob/master/assets/images/changeLocation.png

Or else it's hard to translate! Instead, text should be below, as a RN <Text>

We already added FontAwesome in the app, so we just need to replace the image with FontAwesome location icon + orange circle background

[theNaut1lus]

happy to work on this as my first issue here, please give me the go ahead for this @amaurymartiny

[amaury1093]

Yes, please go ahead @co16353sidak, thanks!

[theNaut1lus]

@amaurymartiny
instead of implementing a font-awesome setup I thought it would be better if we used a svg with the removed bottom text line, this will aid us in using the pre-existing <Image> layout and by just replacing the png with the svg.
we get all the respnsiveness of svg without the text line. I could create a sample svg and show some mockups here if you want to go ahead with this idea 😃

[amaury1093]

Sounds good to me! Our designer Marcelo has already done the icon, here it is.

location-bt.zip

[lucienbl]

If you already have the icon as svg you can directly add the svg in the app which allows you to make the text translatable.

Edit: Using this to convert the SVG file into a react-native component and this library to use the react-native converted component, however, this requires expo ejecting.

[amaury1093]

Hey @co16353sidak, are you still working on this? Do you need help?

[theNaut1lus]

@amaurymartiny sorry for the delays, was going through my exams 🚀
Give me another day for this 😄
P.S: I will be pinging you if i get stuck

[kiranjd]

@amaurymartiny Just downloaded the zip file containing the location icons. You can minify the images further using tinypng.
I have compressed the images by ~55% overall without compromising on quality.
Here are the compressed images,
location-png-minified.zip

[amaury1093]

Thanks @kiranjd, I appreciate it!

[shakti97]

is this issue still incomplete or done but not marked closed?

[amaury1093]

No, it's incomplete, feel free to take it @shakti97, it's part of Hacktoberfest by the way