Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new expo-status-bar package and added the StatusBar in Screen.tsx #751

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Added new expo-status-bar package and added the StatusBar in Screen.tsx #751

merged 1 commit into from
Oct 1, 2020

Conversation

sarthakpranesh
Copy link
Contributor

Changes

  1. Added a new expo-status-bar package
  2. Added the StatusBar from the new Package to App/Screens/Screens.tsx

closes #321

Signed-off-by: sarthakpranesh [email protected]

Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A follow-up would be to set the background color on each screen to exactly the screen's background color, but this can be done later.

@amaury1093 amaury1093 merged commit 5b34bbf into shootismoke:master Oct 1, 2020
@sarthakpranesh sarthakpranesh deleted the fixStatusBar branch October 2, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status bar issue on Android
2 participants