Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status bar issue on Android #321

Closed
vikrantnegi opened this issue Nov 4, 2019 · 6 comments · Fixed by #751
Closed

Status bar issue on Android #321

vikrantnegi opened this issue Nov 4, 2019 · 6 comments · Fixed by #751
Assignees
@sarthakpranesh
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@vikrantnegi
Copy link
Contributor

Hi,
I installed the app on my Android device and the status bar doesn't seems to have dark-content as specified in the App.tsx.

Device specs:
Name: POCO F1
Android version: 9
MIUI: 10.3.8

Screenshot:
Screenshot_2019-11-04-15-19-40-796_com shitismoke app
@amaury1093 amaury1093 added the help wanted Extra attention is needed label Nov 5, 2019
@DragonSpirit
Copy link
Contributor

DragonSpirit commented Nov 7, 2019 •
edited
Loading

But in App.tsx it changes only for iOS 🤔
It depends on dark theme.
@amaurymartiny I can research this.

DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Dec 21, 2019
@DragonSpirit
shootismoke#321 - Fix android statusbar translucency
dd2afa9
@DragonSpirit DragonSpirit mentioned this issue Dec 21, 2019
Merged
amaury1093 pushed a commit that referenced this issue Dec 29, 2019
@DragonSpirit @amaury1093
fix: Fix android statusbar translucency (#374)
79f3345 
* feat: Expand share dialog on iOS (#250)

* update codestyle

* #321 - Fix android statusbar translucency

* Update barStyle
@amaury1093
Copy link
Member

Closed in #374

@amaury1093 amaury1093 reopened this May 12, 2020
@amaury1093 amaury1093 added good first issue Good for newcomers and removed help wanted Extra attention is needed labels May 12, 2020
@amaury1093
Copy link
Member

I believe I re-introduced this bug in the latest v1.6.0 series. To investigate.

@amaury1093 amaury1093 added the bug Something isn't working label May 12, 2020
@amaury1093
Copy link
Member

Expo 38 introduces a new module only for status bar: https://blog.expo.io/expo-sdk-38-is-now-available-ab6cd30ca2ee. We could use that instead of the low-level RN one

@amaury1093 amaury1093 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@sarthakpranesh
Copy link
Contributor

Hey @amaurymartiny, I would like to resolve this issue. Let me know if I can follow the same style settings implemented in #374

@amaury1093
Copy link
Member

@sarthakpranesh yeah, that should work. Go for it 👍

@sarthakpranesh sarthakpranesh mentioned this issue Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarthakpranesh sarthakpranesh

Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added new expo-status-bar package and added the StatusBar in Screen.tsx
4 participants
@DragonSpirit @amaury1093 @vikrantnegi @sarthakpranesh