fix unique over a dimension to use isequal over == (JuliaLang#42737)

shirodkara · Oct 21, 2021 · 011fda9 · 011fda9
1 parent dc46ad9
commit 011fda9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/base/multidimensional.jl b/base/multidimensional.jl
@@ -1666,7 +1666,7 @@ _unique_dims(A::AbstractArray, dims::Colon) = invoke(unique, Tuple{Any}, A)
  else
  j_d = i_d
  end) begin
- if (@nref $N A j) != (@nref $N A i)
+ if !isequal((@nref $N A j), (@nref $N A i))
  collided[k] = true
  end
  end
@@ -1696,7 +1696,7 @@ _unique_dims(A::AbstractArray, dims::Colon) = invoke(unique, Tuple{Any}, A)
  j_d = i_d
  end
  end begin
- if (@nref $N A j) != (@nref $N A i)
+ if !isequal((@nref $N A j), (@nref $N A i))
  nowcollided[k] = true
  end
  end

diff --git a/test/arrayops.jl b/test/arrayops.jl
@@ -791,6 +791,10 @@ let A, B, C, D
 
  # With hash collisions
  @test map(x -> x.x, unique(map(HashCollision, B), dims=1)) == C
+
+ # With NaNs:
+ E = [1 NaN 3; 1 NaN 3; 1 NaN 3];
+ @test isequal(unique(E, dims=1), [1 NaN 3])
 end
 
 @testset "large matrices transpose" begin