Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placement values and modifiers according to popper.js API (#259) #260

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

tedbeer
Copy link
Contributor

@tedbeer tedbeer commented Oct 3, 2018

popper.js placement values are: auto|top|bottom|left|right and modifiers are -start|-end

Closes #259

@RobbieTheWagner
Copy link
Member

@BrianSipple will merging this mess up your tippy refactor stuff and/or does the tippy refactor render this change obsolete? We should probably just pass the directions in, without checking against the regex and let the libraries that consume those directions spit out errors, right?

@BrianSipple
Copy link
Contributor

@rwwagner90 There are a few pieces to that....

Tippy does support a placement option directly. However, we're currently parsing the placement setting out of the Step.attachTo option and merging it in to the tippy.popperOptions hash.

Ideally, we change attachTo to only be concerned with the element (see https://github.com/shipshapecode/shepherd/projects/2#card-13473896). But that's the kind of larger change we decided to hold off on until after the initial Tippy integration.

So with all that said... I think this change is good to go. (Thanks @tedbeer!)

@RobbieTheWagner RobbieTheWagner merged commit e3e95ec into shipshapecode:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants