Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Customizable route path, supports for SQLite and some improvements #3

Merged
merged 4 commits into from
May 12, 2024

Conversation

sethsandaru
Copy link
Member

@sethsandaru sethsandaru commented May 12, 2024

Closes #2

Configuration

We can now customize the route path via config('inbox.route_path'), by default it is inbox

Added SQLite support

SQLite is fast, minimal, and could be really useful for applications that only need to record msgs, resolve them, and flush the inbox msgs frequently.

Improvements

Authorize & Validate

Now you can implement authorize and rules for your Request class. The built-in inbox HTTP layer will make sure both will be run to ensure the requests are legit to go into DB.

Best practices: use authorize to check the signature of the payload (signing, validating, etc) and use rules to ensure the payload is good enough.

Covered in tests.

Removed composer.lock

Like every other PHP packages, we only need composer.json which includes every dependency and information.

@sethsandaru sethsandaru self-assigned this May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (e0a73c3) to head (8072609).

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #3      +/-   ##
============================================
+ Coverage     96.37%   96.44%   +0.07%     
- Complexity       56       57       +1     
============================================
  Files            13       13              
  Lines           248      253       +5     
============================================
+ Hits            239      244       +5     
  Misses            9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethsandaru sethsandaru merged commit dae299e into main May 12, 2024
5 checks passed
@sethsandaru sethsandaru deleted the v1.1.1 branch May 12, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports "customize" built-in inbox route
1 participant