Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum worker control #2070

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ppfeister
Copy link
Member

@ppfeister ppfeister commented Apr 8, 2024

Closes #2059

Argument --workers is added to Sherlock, default 20, allowing the user to specify the maximum number of workers. If the target list is shorter than the maximum, it will not create more workers than targets. No upper limit applied to argument, but the value should be type safe.

Validated with values both higher and lower than the default.


On most capable machines, the bottleneck is the response time of individual targets rather than process time. This can't help very much with response time.

It does allow you to better control worker count in very-low-power situations or in those that have consistently delayed results (to avoid stacked delays). Users using --tor would likely see the most benefit, since those loading times can stack.

Discretionary feature PR

Argument --max-workers is added to Sherlock, default 20, allowing the user to specify the maximum number of workers.
If the sitelist is lower than the maximum, it will not create more workers than sites.
@ppfeister ppfeister changed the title Add multiprocessing control (closes #2059) Add multiprocessing control (Resolves #2509) Apr 8, 2024
@ppfeister ppfeister changed the title Add multiprocessing control (Resolves #2509) Add multiprocessing control Apr 8, 2024
@ppfeister ppfeister changed the title Add multiprocessing control Add maximum worker control Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiprocessing control.
1 participant