Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify 438E as Pure Cool Formaldehyde, and add formaldehyde env data #12

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Identify 438E as Pure Cool Formaldehyde, and add formaldehyde env data #12

merged 2 commits into from
Jul 30, 2021

Conversation

seanrees
Copy link
Contributor

Hey there, this is motivated by seanrees/prometheus-dyson#13 to support the Dyson Pure Cool Formaldehyde. After chatting with the requestor, we identified this as model 438E.

This creates a new DysonPureCoolFormaldehyde class in dyson_pure_cool.py. As far as I can tell, the new model behaves just like a PureCool but with the extra metric. So in this case I simply added it to dyson_pure_cool.py and extended directly from DysonPureCool. I also updated the references throughout libdyson from PURE_COOL_2021 to PURE_COOL_FORMALDEHYDE.

I didn't add a test for this. I wanted to run this design by you first before I did -- if there's another way you prefer this to be implemented, let me know. :-)

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #12 (dd1aba8) into main (ff136d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   99.04%   99.05%           
=======================================
  Files          21       21           
  Lines         941      948    +7     
=======================================
+ Hits          932      939    +7     
  Misses          9        9           
Impacted Files Coverage Δ
libdyson/__init__.py 100.00% <100.00%> (ø)
libdyson/const.py 100.00% <100.00%> (ø)
libdyson/dyson_pure_cool.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff136d2...dd1aba8. Read the comment docs.

@seanrees
Copy link
Contributor Author

Gentle ping on this @shenxn ? (looking for directional feedback :))

Copy link
Owner

@shenxn shenxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. It looks good. Just add some tests then we can get it merged. Thanks

@seanrees
Copy link
Contributor Author

Thanks, added a test.

@shenxn shenxn changed the base branch from main to dev July 30, 2021 13:35
@shenxn shenxn merged commit 1898e35 into shenxn:dev Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants