Identify 438E as Pure Cool Formaldehyde, and add formaldehyde env data #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, this is motivated by seanrees/prometheus-dyson#13 to support the Dyson Pure Cool Formaldehyde. After chatting with the requestor, we identified this as model 438E.
This creates a new
DysonPureCoolFormaldehyde
class in dyson_pure_cool.py. As far as I can tell, the new model behaves just like a PureCool but with the extra metric. So in this case I simply added it to dyson_pure_cool.py and extended directly from DysonPureCool. I also updated the references throughoutlibdyson
from PURE_COOL_2021 to PURE_COOL_FORMALDEHYDE.I didn't add a test for this. I wanted to run this design by you first before I did -- if there's another way you prefer this to be implemented, let me know. :-)