Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement suggestions #3

Closed
osavsunenko-ring opened this issue Dec 13, 2019 · 1 comment
Closed

Performance improvement suggestions #3

osavsunenko-ring opened this issue Dec 13, 2019 · 1 comment

Comments

@osavsunenko-ring
Copy link

Dear shenwei,

If you'd like to get significant performance gains in your BWT you could switch to suffixarray from Go standard library. It operates in linear time, while you implementation doesn't. Here's a comparison - https://github.com/crazyleg/burrow-wheelers-golang

@shenwei356
Copy link
Owner

Thank you so much, it's 4X faster!

$ benchcmp old.txt new.txt
benchmark                 old ns/op     new ns/op     delta
BenchmarkTransform-16     1339346       310706        -76.80%

benchmark                 old allocs     new allocs     delta
BenchmarkTransform-16     4              5              +25.00%

benchmark                 old bytes     new bytes     delta
BenchmarkTransform-16     55362         79962         +44.43%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants