Support for views #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg-osc will now re-create any views after the table name swap. Because pg-osc uses shadow tables, after the name swap happens, views can continue to refer the old table name. This isn't ideal. Instead, we now perform a CREATE OR REPLACE VIEW... after the swap is perform. We do it after swap to ensure any view creation doesn't keep the exclusive lock held for a longer duration
jfrost
reviewed
May 22, 2023
lib/pg_online_schema_change/query.rb
Outdated
| @@ -301,6 +301,21 @@ def storage_parameters_for(client, table, reuse_trasaction = false) | |||
| columns.first | |||
| end | |||
|
|
|||
| def view_definitions_for(client, table) | |||
| query = <<~SQL | |||
| select * | |||
There was a problem hiding this comment.
I think we can probably do better than this query. We should be able to use pg_depend like this postgres wiki article details.
There was a problem hiding this comment.
ah nice! good call. Updated!
|
Good for review now. Will release it today/tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg-osc will now re-create any views after the table name swap. Because pg-osc uses shadow tables, after the name swap happens, views can continue to refer the old table name. This isn't ideal.
Instead, we now perform a
CREATE OR REPLACE VIEW... after the swap is performed. We do it after swap to ensure any view creation doesn't keep the exclusive lock held for a longer duration.Closes: #81