Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping past the end of a file should print a warning. #108

Closed
eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #118
Closed

Skipping past the end of a file should print a warning. #108

eth-p opened this issue Oct 23, 2020 · 1 comment · Fixed by #118
Labels
enhancement New feature or request

Comments

@eth-p
Copy link

eth-p commented Oct 23, 2020

Similarly to #107, unknowingly skipping past the end of a file and seeing an empty grid might be confusing for users.

Note: I'm doing a class assignment regarding creating tests (from scratch) for an open-source command line program, and I chose hexyl for it. You might have a couple more of these on the way, depending on what the assignment brings to light :)
@sharkdp sharkdp added the enhancement New feature or request label Oct 24, 2020
@sharkdp
Copy link
Owner

sharkdp commented Oct 24, 2020

Sounds good!

sharkdp added a commit that referenced this issue Oct 30, 2020
@sharkdp
Print warning on empty content
3b38a33 
closes #107
closes #108
@sharkdp sharkdp mentioned this issue Oct 30, 2020
Merged
sharkdp added a commit that referenced this issue Oct 30, 2020
@sharkdp
Print warning on empty content
b1c8606 
closes #107
closes #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print warning on empty content sharkdp/hexyl
2 participants
@sharkdp @eth-p