Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest --fixed-strings on invalid regexps #234

Closed
sharkdp opened this issue Feb 12, 2018 · 3 comments · Fixed by #238
Closed

Suggest --fixed-strings on invalid regexps #234

sharkdp opened this issue Feb 12, 2018 · 3 comments · Fixed by #238
Labels
feature-request good first issue
Milestone
7.0

Comments

@sharkdp
Copy link
Owner

sharkdp commented Feb 12, 2018

Inspired by BurntSushi/ripgrep#709
@PramodBisht
Copy link
Contributor

@sharkdp Can I take this one?

@sharkdp
Copy link
Owner Author

sharkdp commented Feb 18, 2018

Sure! Let me know if you need any help.

PramodBisht added a commit to PramodBisht/fd that referenced this issue Feb 18, 2018
@PramodBisht
Fixes: sharkdp#234
57f1aca 
Giving suggestion to use `--fixed-strings` in case user passes invalid metacharacters as a regex.
@PramodBisht PramodBisht mentioned this issue Feb 18, 2018
Merged
PramodBisht added a commit to PramodBisht/fd that referenced this issue Feb 19, 2018
@PramodBisht
Fixes: sharkdp#234
02c5264 
Giving suggestion to use `--fixed-strings` in case user passes invalid metacharacters as a regex.
sharkdp pushed a commit that referenced this issue Feb 19, 2018
@PramodBisht @sharkdp
Fixes: #234
7e8c224 
Giving suggestion to use `--fixed-strings` in case user passes invalid metacharacters as a regex.
@sharkdp sharkdp added this to the 7.0 milestone Mar 13, 2018
@sharkdp
Copy link
Owner Author

sharkdp commented Mar 26, 2018

This is part of fd v7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Fixed #234: Suggest --fixed-strings on invalid regexps PramodBisht/fd
2 participants
@PramodBisht @sharkdp