Refactor *_update_metrics @db handle

Call update_owner_metrics on owner creation

spec/service/update_owner_metrics_spec.cr

@@ -75,8 +75,8 @@ describe Service::UpdateOwnerMetrics do
  owner_id = Factory.create_owner(db, "me")
  Factory.set_owner(db, owner_id, [myshard1_repo_id, myshard2_repo_id])
 
- service = Service::UpdateOwnerMetrics.new
- service.perform(db)
+ service = Service::UpdateOwnerMetrics.new(db)
+ service.perform
 
  results = db.connection.query_all <<-SQL, as: {Int64, Int32, Int32, Int32, Int32, Int32, Int32, Int32}
  SELECT

spec/service/update_shard_metrics_spec.cr

@@ -11,8 +11,8 @@ describe Service::UpdateShardMetrics do
  puts notice
  end
 
- service = Service::UpdateShardMetrics.new
- service.perform(db)
+ service = Service::UpdateShardMetrics.new(db)
+ service.perform
  end
  end
 end

src/service/create_owner.cr

@@ -1,5 +1,6 @@
 require "../repo/owner"
 require "../fetchers/github_api"
+require "./update_owner_metrics"
 
 struct Service::CreateOwner
  property github_api : Shardbox::GitHubAPI { Shardbox::GitHubAPI.new }
@@ -21,6 +22,7 @@ struct Service::CreateOwner
  # owner does not yet exist, need to insert a new entry
  fetch_owner_info(owner)
  owner.id = @db.create_owner(owner)
+ UpdateOwnerMetrics.new(@db).update_owner_metrics(owner.id)
  end
 
  assign_owner(owner)

src/service/update_owner_metrics.cr

@@ -1,29 +1,23 @@
 require "../db"
 
 struct Service::UpdateOwnerMetrics
- def initialize
+ def initialize(@db : ShardsDB)
  end
 
  def perform
- ShardsDB.transaction do |db|
- perform(db)
- end
- end
-
- def perform(db)
- owner_ids = db.connection.query_all <<-SQL, as: Int64
+ owner_ids = @db.connection.query_all <<-SQL, as: Int64
  SELECT
  id
  FROM
  owners
  SQL
  owner_ids.each do |id|
- update_owner_metrics(db, id)
+ update_owner_metrics(id)
  end
  end
 
- def update_owner_metrics(db, id)
- db.connection.exec <<-SQL, id
+ def update_owner_metrics(id)
+ @db.connection.exec <<-SQL, id
  SELECT owner_metrics_calculate($1)
  SQL
  end

src/service/update_shard_metrics.cr

@@ -1,29 +1,23 @@
 require "../db"
 
 struct Service::UpdateShardMetrics
- def initialize
+ def initialize(@db : ShardsDB)
  end
 
  def perform
- ShardsDB.transaction do |db|
- perform(db)
- end
- end
-
- def perform(db)
- shard_ids = db.connection.query_all <<-SQL, as: Int64
+ shard_ids = @db.connection.query_all <<-SQL, as: Int64
  SELECT
  id
  FROM
  shards
  SQL
  shard_ids.each do |id|
- update_shard_metrics(db, id)
+ update_shard_metrics(id)
  end
  end
 
- def update_shard_metrics(db, id)
- db.connection.exec <<-SQL, id
+ def update_shard_metrics(id)
+ @db.connection.exec <<-SQL, id
  SELECT shard_metrics_calculate($1)
  SQL
  end

src/worker.cr

@@ -64,8 +64,10 @@ when "sync_repo"
 
  sync_all_pending_repos
 when "update_metrics"
- Service::UpdateShardMetrics.new.perform
- Service::UpdateOwnerMetrics.new.perform
+ ShardsDB.transaction do |db|
+ Service::UpdateShardMetrics.new(db).perform
+ Service::UpdateOwnerMetrics.new(db).perform
+ end
 when "loop"
  Service::WorkerLoop.new.perform
 else