Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lib utils cleanup #7646

Merged
merged 8 commits into from
Aug 28, 2024
Merged

feat: lib utils cleanup #7646

merged 8 commits into from
Aug 28, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Aug 28, 2024

Description

Removes some spotted useless utils:

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • proceed to a paranoia test of bps and quote amounts and ensure things still look good amounts-wise: no extra 0s or super low precision

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

  • ^

Screenshots (if applicable)

@gomesalexandre gomesalexandre marked this pull request as ready for review August 28, 2024 17:11
@gomesalexandre gomesalexandre requested a review from a team as a code owner August 28, 2024 17:11
@kaladinlight
Copy link
Contributor

remove from package/utils/src/bignumber as well? or just waiting on cleaning up the dupe bignumber utils?

@gomesalexandre
Copy link
Contributor Author

remove from package/utils/src/bignumber as well? or just waiting on cleaning up the dupe bignumber utils?

Might as well - not sure yet how much effort it will be to get web packages to work in packages so that may or may not be a now thing! daf2518

@gomesalexandre gomesalexandre enabled auto-merge (squash) August 28, 2024 22:40
@gomesalexandre gomesalexandre merged commit 73b2e20 into develop Aug 28, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_lib_utils_cleanup branch August 28, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants