Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show chain not supported on rFOX claim #7617

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

0xApotheosis
Copy link
Contributor

Description

As a follow-up (and inspired by) to #7600, this PR ensures we show the <ChainNotSupported /> component when connected to a wallet that does not support arbitrum.

This PR:

Screenshot 2024-08-26 at 9 21 18 AM

develop:

When attempting to stake FOX on Arbitrum without an Arbitrum account connected:

Screenshot 2024-08-26 at 9 05 11 AM

When attempting to stake FOX on Ethereum without an Arbitrum account connected (the bridge can never complete because there is no account to sign or pay gas on Arbitrum):

Screenshot 2024-08-26 at 9 23 42 AM

Issue (if applicable)

Follow-up of #7600

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

rFOX staking.

Testing

  • Ensure that rFOX staking works as it does in production when an Arbitrum account is connected.
  • Ensure that the <ChainNotSupported /> component shows on the staking tab when an Arbitrum account is not connected.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

See above.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner August 25, 2024 23:27
@NeOMakinG NeOMakinG self-requested a review August 26, 2024 07:11
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing on mobile so no runtime test and stamp just yet but conceptually looks good to me!

Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported

image

Supported

image

@NeOMakinG NeOMakinG merged commit c37a352 into develop Aug 26, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the hide-stake-no-arb branch August 26, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants