Improve tests result consistency #581
Conversation
In this commit, a deply is put between UI interaction and database check. This, fixed false positive test pass for not updating database on empty form submission.
f46430b
to
79ed86d
Compare
spec/stimulus/turbo_spec.rb
Outdated
| sleep(1) | ||
|
|
||
| # This will ensure we wait enough for the changes to be applied | ||
| expect(page).to have_text("") |
There was a problem hiding this comment.
@ahangarha, this is a very strange assertion!
Please add self-review comments for WTF's like this!
CC: @Judahmeek
There was a problem hiding this comment.
As I mentioned in the comment above that line, we need to put some delay before getting assertion for comment count change. Before I fixed it with sleep but that is not efficient. This assertion makes it more efficient.
There was a problem hiding this comment.
expect page to display the new comment in the right format block (not in the input field).
There was a problem hiding this comment.
We already had a test to ensure the new comment is displayed on the page. This test was to ensure the comment was added to the database.
Now, we combine them into one test with multiple assertions.
| @@ -52,27 +52,36 @@ | |||
| fill_in author_field, with: comment.author | |||
| fill_in text_field, with: comment.text | |||
There was a problem hiding this comment.
make sure the text is some unique value
There was a problem hiding this comment.
When this test runs, we have a fresh database.
spec/stimulus/turbo_spec.rb
Outdated
| sleep(1) | ||
|
|
||
| # This will ensure we wait enough for the changes to be applied | ||
| expect(page).to have_text("") |
There was a problem hiding this comment.
expect page to display the new comment in the right format block (not in the input field).
spec/stimulus/turbo_spec.rb
Outdated
| sleep(1) | ||
|
|
||
| # This will ensure we wait enough for the changes to be applied | ||
| expect(page).to have_text("") |
|
@ahangarha see my changes. |
The changes in
rescript_spec.rbandturbo_spec.rbimprove our test accuracy.The changes inspec/system/*fix the test failure when these tests run before others (leading to their failure).I am not sure why we have tests in thesystemdirectory that should have the type offeature, but it fixes our issues. I need to study deeper to understand what is happening under the hood.Should I move thesefeaturetests into thefeaturedirectory, or we can keep them this way for now?This change is