Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging apps via github actions #579

Merged
merged 17 commits into from
Jan 5, 2024
Merged

Staging apps via github actions #579

merged 17 commits into from
Jan 5, 2024

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Dec 30, 2023

This change is Reviewable

@@ -53,6 +54,8 @@ RUN apt-get update -qq && \
COPY --from=build /usr/local/bundle /usr/local/bundle
COPY --from=build /app /app

RUN chmod +x /app/.controlplane/*.sh
Copy link
Member Author

@justin808 justin808 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borela is this typical? Without, the file permissions were unset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the files were committed to the repo without +x permission, you can fix that, commit the files again, and remove that chmod.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did and it didn't fix the issue.

@justin808 justin808 changed the title Justin808 staging apps Staging apps via github actions Jan 5, 2024
@justin808 justin808 merged commit 3e4d754 into master Jan 5, 2024
3 checks passed
@justin808 justin808 deleted the justin808-staging-apps branch January 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants