Add npm Karma plugins and rake task for JavaScript testing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2015 18:32
| @@ -0,0 +1,5 @@ | |||
| desc "Run Karma tests" | |||
| task :test do | |||
There was a problem hiding this comment.
Let's rename this file js_tests.rake and the task as well to js_tests.
We can have a test task that does both rspec and karma.
|
We can get some inspiration on the React components to test here: https://github.com/react-bootstrap/react-bootstrap/blob/master/test/ButtonSpec.js @Johnnycus this is a good start! The goal is to provide a clean simple example of how we'd add JS tests to a project like this. This project is in active development: https://github.com/gaearon/redux and it might be the right example. An older project that shows testing of react components: https://github.com/react-bootstrap/react-bootstrap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no project tests, just sample test.