#444 Migrate JS tests to Jest #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
requested changes
Aug 25, 2018
There was a problem hiding this comment.
One big comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sahalsaad)
client/package.json, line 55 at r1 (raw file):
"babel-preset-react": "^6.24.1", "babel-preset-stage-2": "^6.24.1", "babel-runtime": "^6.26.0",
These are needed in to build on heroku so must NOT be moved.
sahalsaad
force-pushed
the
444-migrate-js-test-to-jest
branch
from
57eb2f1
to
1e17c87
Compare
justin808
reviewed
Aug 26, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sahalsaad)
justin808
requested changes
Aug 26, 2018
There was a problem hiding this comment.
one comment
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sahalsaad)
client/.eslintrc.yml, line 17 at r2 (raw file):
browser: true node: true mocha: true
why are we leaving in mocha?
justin808
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is