jscs integration #26
Merged
jscs integration #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2 Errors:
Missing newline after closing curly brace at ./assets/javascripts/CommentBox.jsx :
44 | var newComments = React.addons.update(oldComments, {$push: [newComment]});
45 | this.setState({ajaxSending: false, data: newComments, formData: this.emptyFormData});
46 | }, (xhr, status, err) => {
-------------^
47 | this.logError(xhr, status, err);
48 | this.setState({ajaxSending: false});
Missing newline after closing curly brace at ./assets/javascripts/CommentList.jsx :
19 | <Comment author={comment.author} key={index} text={comment.text}/>
20 | );
21 | });
-------------^
22 | return (
23 | <div className='commentList'>
2 code style errors found.
justin808
force-pushed
the
integrate-jscs
branch
from
e5cca1d
to
4668667
Compare
justin808
added a commit
that referenced
this pull request
Apr 5, 2015
jscs integration -- two known failures -- hopefully addressed with upcoming fixes to jscs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.