Fix Procfiles to use new process names #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,10 +12,6 @@ rails-assets: sh -c 'rm app/assets/webpack/* || true && HOT_RAILS_PORT=3500 npm | |||
| # Keep the JS fresh for server rendering. Remove if not server rendering | |||
| rails-server-assets: sh -c 'npm run build:dev:server' | |||
|
|
|||
| # If you don't keep this process going, you will rebuild the assets per spec run. This is configured | |||
| # in rails_helper.rb. | |||
| rails-test: sh -c 'npm run build:test:client' | |||
There was a problem hiding this comment.
we need this
please don't remove
this is used b/c above we do hot ones
There was a problem hiding this comment.
this is still sort of necessary
robwise
force-pushed
the
fix-procfiles
branch
2 times, most recently
from
34a94a3
to
402a4c1
Compare
robwise
force-pushed
the
fix-procfiles
branch
from
402a4c1
to
736bcc3
Compare
justin808
added a commit
that referenced
this pull request
Feb 8, 2016
Fix Procfiles to use new process names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we just don't need the special
build:test:clientscript anymore, and you can just useProcfile.staticto keep your static assets up to date while running your tests.Also changed the ordering of the scripts so that the client and server versions of the same type of script are next to each other.