Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec tests #20

Merged
merged 7 commits into from
Mar 27, 2015
Merged

Rspec tests #20

merged 7 commits into from
Mar 27, 2015

Conversation

dylangrafmyre
Copy link
Contributor

Add test gems
Add rspec test directory
Configure RSpec settings for test gems
Create Comments feature test for all three comment forms

@@ -18,6 +18,7 @@
client-bundle.js
client-bundle.js.map
.env
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in your global git ignore, not the project one.

@justin808
Copy link
Member

Looks good. Ready for merge?

@dylangrafmyre
Copy link
Contributor Author

I removed .idea from project .gitignore and added it to global. Should be good to go! Thanks!

@dylangrafmyre
Copy link
Contributor Author

At this time Capybara-Webkit and Poltergeist do not work as headless drivers with Capybara
and ReactJS without custom javascript implementation and modified css.
thoughtbot/capybara-webkit#494
teampoltergeist/poltergeist#292
The possible workout arounds create test code that is not easy to understand with required customization and might become brittle in future development.

@dylangrafmyre
Copy link
Contributor Author

By adding node module ES5-SHIM(https://github.com/es-shims/es5-shim) and updating from qt to qt5(thoughtbot/capybara-webkit#494) on my mac, I was able to use Capybara-Webkit instead of Selenium-Webdriver. This enabled faster, headless RSpec feature tests.

@justin808 justin808 merged commit 15338ef into shakacode:master Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants