setting node version on travis #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,8 @@ rvm: | |||
| - 2.2.3 | |||
| install: | |||
| - bundle install | |||
| - nvm install 5.0 | |||
| - nvm use 5.0 | |||
| - npm install -g npm | |||
There was a problem hiding this comment.
@justin808 @MaMute Since we are now installing Node 5.0 with nvm, we can probably remove npm install -g npm. Node 5.0 comes with NPM 3.x.x.
Before travis was using a older version of npm that was failing our build.
There was a problem hiding this comment.
Hi @dylangrafmyre I just merged. Let's do another PR if that's the case.
BTW, I get the linting error locally, so this is probably not the main build issue. There's some problem with eslint?
There was a problem hiding this comment.
@justin808 the main build failure is from a c++ compiler error for NAN module used in sleep. I will fix this. This only for the travis build. The Codeship build fails with the eslint error.
justin808
added a commit
that referenced
this pull request
Dec 2, 2015
setting node version on travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.