Add karma testing using babel/6to5 loader and webpack preprocessor #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinwoo I'm guessing that we we don't need both the jsx loader and the babel one. We'll need to change the webpack config files for this. Thoughts? |
|
@justinwoo: I'd like to get your changes merged. However, with the recent changes to use babel, putting package.json in a subdir, etc., there's lots of changes. I can manually merge or if you like, make a few tweaks and I'll accept your PR. |
|
@justinwoo Closing this now. Lots of updates since when this PR was started. Let's open a new PR to get this done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we should just use the babel/6to5 loader since it's the most feature complete loader and it works out of the box (including JSX transforms).