Ci build issues #114
Merged
Ci build issues #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| end | ||
|
|
||
| Capybara.default_wait_time = 15 |
There was a problem hiding this comment.
Does it need a bit more wait time to have CI pass?
There was a problem hiding this comment.
@samnang this was recommended by travis-ci for failed tests with capybara element not found.
under their common build errors documents. However, this was not why the test were failing. That was later solved by the update dependencies branch. Some updated npm modules had broken the app and the builds during fresh installs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix capybara screenshot render during failing tests by assigning the custom js driver.
Add capybara default_wait_time per Travis CI common build errors:
http:https://docs.travis-ci.com/user/common-build-problems/#Capybara%3A-I%E2%80%99m-getting-errors-about-elements-not-being-found