Update libraries and JSX for current versions 1/23/2015 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbreining @kimagure Any comments? I'll try to get the sass-loader updated next. |
|
You can import CommonJS modules easily, just requires that you do I admit it's not the best thing ever, but it'll work enough. |
|
@justin808, the code in |
|
You can merge as far as I'm concerned. |
* Required a few JSX changes. * Don't use import for commonjs modules * key changed to eventKey for NavItem * Use different names for the the native input HTML elements compared to the react-bootstrap ones * Could not update the sass-loader without errors * Moved all Sass related parts of webpack to the webpack.hot.config.js as Rails version does not use the Webpack sass handlers. * Changed webpack.rails.config.js so that the loader for JSX does not use react-hot * Added the woff2 pattern for the file loader. * Changed from React.renderComponent to React.render in example.jsx.
* New dependency uses proper array iteration * Only affect the hot-reload version
justin808
force-pushed
the
update-to-latest
branch
from
e34c32f
to
17bcd21
Compare
|
@mbreining I rebased master onto my branch and did a push -f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the react-bootstrap ones
as Rails version does not use the Webpack sass handlers.
use react-hot