Remove pwa from withPWA return value

[DavidSint]

In Next 12.2.3 a change was added saying that the next.config.js "must NOT have additional properties" and that the pwa property was considered as an additional property. Therefore, this commit deletes the pwa property from the calculated next config in the default exported function in index.js (aka the withPWA function). The returned next config therefore does not have the pwa field and the warning does not appear.

Resolves #367

[olavoparno]

Can you lint according to what was before and only adjust the removal of the PWA key? This gives everyone much more confort in reviewing this PR

[DavidSint]

I'm not sure exactly what you mean @olavoparno? Are you saying that the PR violates something from a linting rule?

[olavoparno]

@DavidSint it is just that it seems you changed the indentation, didn't you?

[olavoparno]

Oh, you had to create a new object, right? Sorry, I did not notice it.

[DavidSint]

Thanks @olavoparno, so now it appears we have to wait for this workflow to be approved to run first

[shadowwalker]

Thanks for the pull request. I'm a bit behind obviously.

[felixmosh]

This PR breaks the config, since the webpack function takes the pwa from options.config which (doesn't exists anymore).

[ArianHamdi]

Same here. I just started with the 5.5.5 version.

[jamesformica]

Also having an issue. The sw.js (and other files) are no longer being outputted in the public NextJs folder, and are instead being outputted in the .next folder. We are on the latest version of next. This was previously working and nothing in our config has changed other than bumping the patch version. Have downgraded to 5.5.4 but would prefer a proper fix.

[trongithust]

This change make pwa from options.config is always {}. So, the plugin doesn't apply any config.