Update username length #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I wonder whether it would make sense to mention #584 (comment) this as well. |
|
Could you add a tag to the commit? That way, it's easy to check when the change was actually done. (I'm assuming this is documenting that commit 6a1f45d). |
alejandro-colomar
approved these changes
May 8, 2024
There was a problem hiding this comment.
BTW, apart from the Fixes tag and @jubalh 's suggestion for also adding a link, it LGTM.
Reviewed-by: Alejandro Colomar <[email protected]>
Fixes: 6a1f45d ("lib/chkname.c: Support unlimited user name lengths") Related-To: shadow-maint#986 Signed-off-by: Iker Pedrosa <[email protected]> Reviewed-by: Alejandro Colomar <[email protected]>
Signed-off-by: Iker Pedrosa <[email protected]> Reviewed-by: Alejandro Colomar <[email protected]>
|
I added the two references to make it clearer. |
alejandro-colomar
pushed a commit
that referenced
this pull request
May 9, 2024
Fixes: 6a1f45d ("lib/chkname.c: Support unlimited user name lengths") Related-To: #986 Signed-off-by: Iker Pedrosa <[email protected]> Reviewed-by: Alejandro Colomar <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.