getdef: avoid spurious error messages about unknown configuration opt… #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions def_find can return NULL for unset, not just unknown, config options. So move the decision of whether to log an error message about an unknown config option back into def_find, which knows the difference. Only putdef_str() will pass a char* srcfile to def_find, so only calls from putdef_str will cause the message, which was the original intent of fa68441. closes #967 fixes: fa68441 ("Improve the login.defs unknown item error message") Signed-off-by: Serge Hallyn <[email protected]>
alejandro-colomar
approved these changes
Mar 21, 2024
|
LGTM! And it works as expected, so I'm merging it. Thank you Serge! |
alejandro-colomar
pushed a commit
that referenced
this pull request
Mar 21, 2024
…on options def_find can return NULL for unset, not just unknown, config options. So move the decision of whether to log an error message about an unknown config option back into def_find, which knows the difference. Only putdef_str() will pass a char* srcfile to def_find, so only calls from putdef_str will cause the message, which was the original intent of fa68441. Closes: <#967> Fixes: fa68441 ("Improve the login.defs unknown item error message") Signed-off-by: Serge Hallyn <[email protected]> Reviewed-by: Alejandro Colomar <[email protected]> Cherry-picked-from: ead55e9 ("getdef: avoid spurious error messages about unknown configuration options") Link: <https://bugzilla.redhat.com/show_bug.cgi?id=2265291> Link: <#976> Cc: Michael Vetter <[email protected]> Cc: Dominique Leuenberger <[email protected]> Cc: Iker Pedrosa <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions
def_find can return NULL for unset, not just unknown, config options. So move the decision of whether to log an error message about an unknown config option back into def_find, which knows the difference. Only putdef_str() will pass a char* srcfile to def_find, so only calls from putdef_str will cause the message, which was the original intent of fa68441.
closes #967
fixes: fa68441 ("Improve the login.defs unknown item error message")