Skip to content

Commit

Permalink
lib/getrange.c: getrange(): Small refactor
Browse files Browse the repository at this point in the history
Set *has_{min,max} = false at the begining, so we only need to set them
to true later.

This means we set these variables on error, which we didn't do before,
but since we return -1 on error and ignore (don't use) the pointees at
call site, that's fine.

Signed-off-by: Alejandro Colomar <[email protected]>
  • Loading branch information
alejandro-colomar authored and hallyn committed May 4, 2024
1 parent dbd3527 commit 6bf5d6d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/getrange.c
Expand Up @@ -36,6 +36,9 @@ getrange(const char *range,
if (NULL == range)
return -1;

*has_min = false;
*has_max = false;

if ('-' == range[0]) {
if (!isdigit(range[1]))
return -1;
Expand All @@ -46,7 +49,6 @@ getrange(const char *range,
return -1;

/* -<long> */
*has_min = false;
*has_max = true;
*max = n;
} else {
Expand All @@ -68,7 +70,6 @@ getrange(const char *range,
if ('\0' == *endptr) {
/* <long>- */
*has_min = true;
*has_max = false;
*min = n;
} else if (!isdigit (*endptr)) {
return -1;
Expand Down

0 comments on commit 6bf5d6d

Please sign in to comment.