Skip to content

Commit

Permalink
newuidmap and newgidmap manpages: fix fd description
Browse files Browse the repository at this point in the history
The manpages for newuidmap and newgidmap had a typo "[pid[" instead
of "[pid]".  They were also unclear about what the /proc/pid fd should
be.  Fix both.

Closes #977

Reported-by: [email protected]
Signed-off-by: Serge Hallyn <[email protected]>
  • Loading branch information
hallyn authored and ikerexxe committed Apr 10, 2024
1 parent 5f5b21f commit 2e01b9d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions man/newgidmap.1.xml
Expand Up @@ -120,8 +120,8 @@
Instead of an integer process id, the first argument may be
specified as <replaceable>fd:N</replaceable>, where the integer N
is the file descriptor number for the calling process's opened
file for <filename>/proc/[pid[</filename>. In this case,
<command>newgidmap</command> will use
file descriptor for the directory <filename>/proc/[pid]</filename>.
In this case, <command>newgidmap</command> will use
<refentrytitle>openat</refentrytitle><manvolnum>2</manvolnum>
to open the <filename>gid_map</filename> file under that
directory, avoiding a TOCTTOU in case the process exits and
Expand Down
4 changes: 2 additions & 2 deletions man/newuidmap.1.xml
Expand Up @@ -120,8 +120,8 @@
Instead of an integer process id, the first argument may be
specified as <replaceable>fd:N</replaceable>, where the integer N
is the file descriptor number for the calling process's opened
file for <filename>/proc/[pid[</filename>. In this case,
<command>newuidmap</command> will use
file descriptor for the directory <filename>/proc/[pid]</filename>.
In this case, <command>newuidmap</command> will use
<refentrytitle>openat</refentrytitle><manvolnum>2</manvolnum>
to open the <filename>uid_map</filename> file under that
directory, avoiding a TOCTTOU in case the process exits and
Expand Down

0 comments on commit 2e01b9d

Please sign in to comment.