lib/pam_pass_non_interactive.c: use strzero/free

The combination of bzero and free could be optimized away. Reviewed-by: Alejandro Colomar <[email protected]> Signed-off-by: Samanta Navarro <[email protected]>
shadow-maint · Mar 14, 2024 · 2b67dc7 · 2b67dc7
1 parent fce1d88
commit 2b67dc7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/pam_pass_non_interactive.c b/lib/pam_pass_non_interactive.c
@@ -19,6 +19,7 @@
 
 #include "alloc.h"
 #include "attr.h"
+#include "memzero.h"
 #include "prototypes.h"
 #include "shadowlog.h"
 
@@ -97,9 +98,8 @@ static int ni_conv (int num_msg,
 failed_conversation:
  for (count=0; count < num_msg; count++) {
  if (NULL != responses[count].resp) {
- bzero(responses[count].resp,
- strlen(responses[count].resp));
- free (responses[count].resp);
+ strzero(responses[count].resp);
+ free(responses[count].resp);
  responses[count].resp = NULL;
  }
  }