Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warnings for input global variables #4745

Merged

Conversation

venkataram-nv
Copy link
Collaborator

@venkataram-nv venkataram-nv commented Jul 26, 2024

Fixes an undesired warning issued when using GLSL layout variables. The higher level problem is that the warning system was not skipping checks for input global variables.

@venkataram-nv venkataram-nv added the pr: non-breaking PRs without breaking changes label Jul 26, 2024
@venkataram-nv venkataram-nv self-assigned this Jul 26, 2024
@venkataram-nv venkataram-nv marked this pull request as draft July 26, 2024 18:47
@venkataram-nv venkataram-nv changed the title Disable warnings for GLSL layout variables Disable warnings for input global variables Jul 26, 2024
@venkataram-nv venkataram-nv marked this pull request as ready for review July 26, 2024 19:01
jkwak-work
jkwak-work previously approved these changes Jul 26, 2024
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

tests/diagnostics/uninitialized-globals.slang Outdated Show resolved Hide resolved
csyonghe
csyonghe previously approved these changes Jul 26, 2024
@venkataram-nv venkataram-nv merged commit c0bff66 into shader-slang:master Jul 26, 2024
11 checks passed
@venkataram-nv venkataram-nv deleted the glsl-layout-no-warnings branch July 26, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants