Warnings target switch intrinsic asm #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkataram-nv
force-pushed
the
warnings-target-switch-intrinsic-asm
branch
from
7e373a1
to
5f3eb0f
Compare
csyonghe
reviewed
Jul 24, 2024
csyonghe
reviewed
Jul 24, 2024
jkwak-work
reviewed
Jul 24, 2024
csyonghe
reviewed
Jul 24, 2024
csyonghe
reviewed
Jul 24, 2024
…witch-intrinsic-asm
jkwak-work
reviewed
Jul 25, 2024
ArielG-NV
reviewed
Jul 25, 2024
ArielG-NV
reviewed
Jul 25, 2024
csyonghe
reviewed
Jul 26, 2024
| @@ -16,23 +16,8 @@ struct ReachabilityContext | |||
| ReachabilityContext() = default; | |||
| ReachabilityContext(IRGlobalValueWithCode* code); | |||
|
|
|||
| bool isInstReachable(IRInst* from, IRInst* to); | |||
There was a problem hiding this comment.
We can revert this change and move isInstReachable to its original place?
There was a problem hiding this comment.
We can but after switching to getBlock calls we would also need to #include "slang-ir-util.h" in slang-ir-reachabilty.h is that fine?
There was a problem hiding this comment.
Ah, I see, moving it here is fine.
csyonghe
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #4720
Also adds a fix to skip generating IR for empty target switches. Previously this would result in generating an unreachable block, which would have necessitated special handling for target switches.