Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kabit Savaiye Corrections #1222

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

Kabit Savaiye Corrections #1222

wants to merge 2 commits into from

Conversation

bhajneet
Copy link
Member

@bhajneet bhajneet commented Sep 29, 2019

For correctors:

For developers:

  • Citation to use in git commits
    • Singh, Bh. Sewa. Kabit Savaiye Bhai Gurdaas Ji Steek. 7th ed., Singh Brothers Amritsar, Dec 2011, <PAGE>, www.sikhbookclub.com/Book/Kabit-Sawaiye-Bhai-Gurdas-Ji-Steek3. Accessed 22 Jan 2019.
    • Where <PAGE> can be p. 43 or pp. 43-44. Most likely all of these will be found on a single page. Use the physical page found in the photo of the PDF and not the page number of the PDF document itself.

Example git commit

fix(data/kabit-savaiye): update id 1IL! to match physical proof

Singh, Bh. Sewa. Kabit Savaiye Bhai Gurdaas Ji Steek. 7th ed., Singh Brothers Amritsar, Dec 2011, p. 43, www.sikhbookclub.com/Book/Kabit-Sawaiye-Bhai-Gurdas-Ji-Steek3. Accessed 22 Jan 2019.

Closes #9001

Sanitization:

  • In-place bindi ˆ vs stand-alone bindi N
    • to yN
    • to YN
    • to oN
    • to ON
    • to IN
    • auˆ to auN
  • Confirm extended accents ü/¨
    • Ru to
    • RU to
    • HU to §
  • Convert wN to W
  • Check ~ vs ` (Adhak)
  • Check nUM vs nUµ
  • Check R vs ®
  • Check ´ vs Ï (Pair yayya)
  • Check N vs ˆ
  • Check for any whitespace before vishraams
  • Check for apostrophes/hyphens/pair-bindi akhar in gurmukhi and act accordingly (have a discussion if unsure)
  • Remove any superscript numbers (i.e. ¹, ², ³, ⁴, ⁵, ...)
  • Missing data from varchar(255) import, use regex search : "(.{255})",

@bhajneet bhajneet added Impacts All Affects nearly all or all end-users! Scope: Data/Kabit Savaiye Status: In Progress ○ Type Bug Regressions/production issues that do not function as intended. labels Sep 30, 2019
@Harjot1Singh Harjot1Singh changed the base branch from master to dev March 18, 2020 15:52
@bhajneet bhajneet marked this pull request as draft May 4, 2020 14:39
@bhajneet bhajneet changed the title [WIP] Kabit Savaiye Corrections Kabit Savaiye Corrections May 4, 2020
Base automatically changed from dev to main February 7, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts All Affects nearly all or all end-users! Scope: Data/Kabit Savaiye ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants