Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-json moving subsection key in JSON #1786

Closed
sarabveer opened this issue Jun 8, 2020 · 1 comment · Fixed by #1790
Closed

build-json moving subsection key in JSON #1786

sarabveer opened this issue Jun 8, 2020 · 1 comment · Fixed by #1790
Assignees
@Harjot1Singh @saihaj
Labels
Effort 0 Non-work/tracking Impacts All Affects nearly all or all end-users! Scope: Build Issues affecting the build process ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@sarabveer
Copy link
Collaborator

sarabveer commented Jun 8, 2020 •
edited
Loading

Describe the bug
The build-json command is moving the subsection key in the json files, which modifies all of the json files.

To Reproduce
Run build-sqlite and then build-json

Expected behavior

    "id": "CSQ",
    "sttm_id": null,
    "writer": "SGPC",
    "section": "Ardaas",
    "subsection": "Ardaas",

Screenshots

    "id": "CSQ",
    "sttm_id": null,
    "subsection": null,
    "writer": "SGPC",
    "section": "Ardaas",
@sarabveer sarabveer added ○ Type Bug Regressions/production issues that do not function as intended. Impacts All Affects nearly all or all end-users! Status: To Do Effort 0 Non-work/tracking labels Jun 8, 2020
@shabados-bot shabados-bot added the Scope: Data/Ardaas User/developer question label Jun 8, 2020
@sarabveer sarabveer removed the Scope: Data/Ardaas User/developer question label Jun 8, 2020
@shabados-bot shabados-bot added the Scope: Data/Ardaas User/developer question label Jun 8, 2020
@sarabveer sarabveer added Scope: Build Issues affecting the build process and removed Scope: Data/Ardaas User/developer question labels Jun 8, 2020
@saihaj saihaj self-assigned this Jun 22, 2020
@shabados-bot shabados-bot added the Scope: Data/Ardaas User/developer question label Jun 22, 2020
@saihaj saihaj removed the Scope: Data/Ardaas User/developer question label Jun 22, 2020
@saihaj
Copy link
Member

saihaj commented Jun 22, 2020 •
edited
Loading

If I log at L124 then it is expected order but when I log at L125 the order changes for subsection

https://github.com/ShabadOS/database/blob/4b8400850237b0bc7cab5e7cecc45b241af8c5a0/lib/build-json.js#L123-L128

saihaj added a commit to saihaj/ShabadOSdatabase that referenced this issue Jun 23, 2020
@saihaj
fix(build): explicilty set keys instead of spreading
9e49e31 
Fixes shabados#1786
@saihaj saihaj mentioned this issue Jun 23, 2020
Merged
saihaj added a commit to saihaj/ShabadOSdatabase that referenced this issue Jun 23, 2020
@saihaj
fix(build): explicilty set keys instead of spreading
b32f6ef 
Fixes shabados#1786
saihaj added a commit to saihaj/ShabadOSdatabase that referenced this issue Jun 24, 2020
@saihaj
fix(build): explicilty set keys instead of spreading
2b58429 
Fixes shabados#1786
saihaj added a commit to saihaj/ShabadOSdatabase that referenced this issue Jun 24, 2020
@saihaj
build: explicilty set keys instead of spreading
2fa8142 
Fixes shabados#1786
Harjot1Singh pushed a commit that referenced this issue Jun 24, 2020
@saihaj @Harjot1Singh
build: explicilty set keys instead of spreading
fcc6d91 
Fixes #1786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harjot1Singh Harjot1Singh

@saihaj saihaj

Labels
Effort 0 Non-work/tracking Impacts All Affects nearly all or all end-users! Scope: Build Issues affecting the build process ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: build-json moving subsection saihaj/ShabadOSdatabase
4 participants
@Harjot1Singh @sarabveer @shabados-bot @saihaj