Support stream=True in v1/completions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
force-pushed
the
cody/openai-completion
branch
from
6d9fbec
to
a6acdf3
Compare
|
This looks good. Let me take this over and make the frontend compatible with your new changes |
|
Sure. Feel free push necessary changes, and I'll rebase the chat completion API once this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1/completionsprotocol compatible with OpenAI API.v1/completions.\n\nso that it could be compatible with other frameworks.On my local, all tests in
tests/srt/test_httpserver_*andtests/srt/test_openai_server.pyare passed.