Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logit processor bugs #427

Merged
merged 7 commits into from
May 12, 2024
Merged

Fix logit processor bugs #427

merged 7 commits into from
May 12, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy merged commit aee4f52 into main May 12, 2024
@merrymercy merrymercy deleted the fix-bugs branch May 12, 2024 11:54
@qeternity
Copy link
Contributor

Hi @merrymercy - this PR removes the hit_stop_str that was added the other day in my PR.

This ends up being useful to determine why a model stopped generating in certain contexts.

Was this removed intentionally?

@merrymercy merrymercy mentioned this pull request May 12, 2024
Merged
@merrymercy
Copy link
Contributor Author

@qeternity Hi, sorry for this. It is unintentional. I added it back in #432

@qeternity
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@merrymercy @qeternity