Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #410 due to missing
sync()
operation whenfork(1)
.History review:
fork > 1
condition, which tries to resolve the racing condition. This can be done by only a sync(?)fork(1)
#375 reverts the condition to reduce the overhead of caching in benchmark react, but it brings a racing condition back.To solve these two problems, we always sync before forking and only commit lazily when fork num > 1.