Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing the unused imports #385

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Revert removing the unused imports #385

merged 2 commits into from
Apr 23, 2024

Conversation

hnyls2002
Copy link
Collaborator

Reverts #378

Some public APIs are broken, such as from sglang import RuntimeEndpoint, this is because the former PR falsely removed these imports.

The public API should follow the format of __all__=[...].

@hnyls2002 hnyls2002 changed the title Revert "add .isort.cfg" Revert removing the unused imports Apr 23, 2024
@hnyls2002 hnyls2002 merged commit 150d702 into main Apr 23, 2024
@hnyls2002 hnyls2002 deleted the revert-378-fix-isort branch April 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant