Compat with latest VLLM 0.4.2 main + fork.number rename + Flashinfer 0.0.4 #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to int cast
merrymercy
requested changes
Apr 30, 2024
|
@Qubitium Thanks for the contributions! We would like to merge this soon. |
|
@merrymercy The vllm main is moving quite fast. We have not tested main compatibility as of today and staff is on a 5 day vacation so response will be delayed. |
|
@merrymercy Remerged with vllm main as of today and confirmed working. |
Qubitium
changed the title
Qubitium
changed the title
# Conflicts: # python/sglang/srt/utils.py
merrymercy
approved these changes
May 11, 2024
|
@Qubitium @ZhouXingg Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR:
fork(number=N)param tofork(size=N)for clarity.